Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add http.lua_shared_dict.prometheus-metrics annotation in config.yaml.example file #11552

Conversation

MrLinMH
Copy link
Contributor

@MrLinMH MrLinMH commented Sep 5, 2024

Description

Add http.lua_shared_dict.prometheus-metrics annotation in config.yaml.example file

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. doc Documentation things labels Sep 5, 2024
@@ -252,7 +252,7 @@ nginx_config: # Config for render the template to generate n
internal-status: 10m
plugin-limit-req: 10m
plugin-limit-count: 10m
prometheus-metrics: 10m
prometheus-metrics: 10m # In production, it is recommended that the memory usage does not exceed 50MB
Copy link
Member

@membphis membphis Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prometheus-metrics: 10m # In production, it is recommended that the memory usage does not exceed 50MB
prometheus-metrics: 10m # In production, less than 50m is recommended

@membphis
Copy link
Member

membphis commented Sep 5, 2024

docs: add ...
to
`chore: add ...

@MrLinMH MrLinMH changed the title docs: add http.lua_shared_dict.prometheus-metrics annotation in config.yaml.example file chore: add http.lua_shared_dict.prometheus-metrics annotation in config.yaml.example file Sep 5, 2024
@kayx23 kayx23 merged commit a628ba1 into apache:master Sep 6, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation things size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants