Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: the timeout of healthcheck should be number type. #1892

Merged
merged 4 commits into from
Jul 27, 2020
Merged

change: the timeout of healthcheck should be number type. #1892

merged 4 commits into from
Jul 27, 2020

Conversation

membphis
Copy link
Member

@membphis membphis commented Jul 23, 2020 •
edited
Loading

What this PR does / why we need it:

as title. eg: 1.05 means 1005 millisecond.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@membphis membphis marked this pull request as ready for review July 23, 2020 06:55
moonming
moonming reviewed Jul 24, 2020
View reviewed changes
doc/health-check.md Outdated Show resolved Hide resolved
@moonming moonming merged commit 4015071 into apache:master Jul 27, 2020
@membphis membphis deleted the healthcheck-timeout-number branch July 27, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@membphis @moonming