Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade skywalking plugin to support skywalking 8.0 . #2389

Merged
merged 20 commits into from
Oct 29, 2020
Merged

feat: upgrade skywalking plugin to support skywalking 8.0 . #2389

merged 20 commits into from
Oct 29, 2020

Conversation

membphis
Copy link
Member

@membphis membphis commented Oct 11, 2020 •
edited
Loading

What this PR does / why we need it:

fix #2072

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@membphis membphis marked this pull request as ready for review October 23, 2020 14:50
@membphis membphis changed the title feat: upgrade skywalking plugin to support skywalking 8.0 . [WIP] feat: upgrade skywalking plugin to support skywalking 8.0 . Oct 23, 2020
@gxthrj
Copy link
Contributor

gxthrj commented Oct 28, 2020

There are some files conflict

@membphis membphis changed the title [WIP] feat: upgrade skywalking plugin to support skywalking 8.0 . feat: upgrade skywalking plugin to support skywalking 8.0 . Oct 28, 2020
@membphis
Copy link
Member Author

@gxthrj @moonming fixed conflicts, please take a look when you have time.

spacewander
spacewander reviewed Oct 29, 2020
View reviewed changes
doc/plugins/skywalking.md Outdated Show resolved Hide resolved
doc/plugins/skywalking.md Outdated Show resolved Hide resolved
apisix/plugins/skywalking.lua Show resolved Hide resolved
apisix/plugins/skywalking.lua Show resolved Hide resolved
@moonming moonming added this to the 2.1 milestone Oct 29, 2020
@moonming moonming merged commit b23475f into apache:master Oct 29, 2020
@membphis membphis deleted the skywalking-2.0 branch October 29, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@gxthrj gxthrj gxthrj approved these changes

@moonming moonming moonming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

upgrade skywalking plugin to support skywalking 8.0
4 participants
@membphis @gxthrj @spacewander @moonming