change: don't treat route segment with ':' as parameter by default #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
force-pushed
the
colon_match
branch
from
2fe0dcb
to
a140eae
Compare
spacewander
changed the title
|
Another related issue: #2008 |
membphis
reviewed
Dec 29, 2020
tokers
approved these changes
Dec 29, 2020
membphis
requested changes
Dec 29, 2020
conf/config-default.yaml
Outdated
| @@ -119,6 +119,8 @@ apisix: | |||
| # control: | |||
| # ip: "127.0.0.1" | |||
| # port: 9090 | |||
| feature: | |||
| enable_parameter_in_route: false # allow using ':param' in the router. See https://github.com/api7/lua-resty-radixtree/#parameters-in-path | |||
There was a problem hiding this comment.
@membphis
rewritten.
|
We decide to use |
Fix apache#3134. You can still get the original behavior by using radixtree_uri_with_parameter router. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
force-pushed
the
colon_match
branch
from
a140eae
to
adf3ff8
Compare
|
need to add some comment here: https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L89-L91 |
|
@membphis |
|
many thx, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3134.
Signed-off-by: spacewander spacewanderlzx@gmail.com
What this PR does / why we need it:
Pre-submission checklist: