Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set conf info when global rule is hit without matched rule #3332

Merged
merged 1 commit into from
Jan 20, 2021
Merged

fix: set conf info when global rule is hit without matched rule #3332

merged 1 commit into from
Jan 20, 2021

Conversation

spacewander
Copy link
Member

Fix #3330

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
fix: set conf info when global rule is hit without matched rule
b04d7ae 
Fix apache#3330

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review January 19, 2021 04:17
@spacewander spacewander merged commit b78c87a into apache:master Jan 20, 2021
@spacewander spacewander deleted the 3330 branch January 20, 2021 03:21
@spacewander spacewander mentioned this pull request Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: /apisix/prometheus/metrics cannot access
3 participants
@spacewander @juzhiyuan @tokers