feat: kafka-logger implemented reuse kafka producer #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add test cases later |
spacewander
reviewed
Jan 27, 2021
get partition_id for test case and debug
tokers
reviewed
Jan 27, 2021
Firstsawyou
reviewed
Jan 27, 2021
tokers
reviewed
Jan 28, 2021
|
@spacewander @tokers @Firstsawyou CI is broken? |
|
The CI is up now. You might need to submit a new commit to trigger it. |
|
got |
|
update, @spacewander @tokers @Firstsawyou pls take a look |
tokers
reviewed
Jan 29, 2021
spacewander
approved these changes
Jan 29, 2021
tokers
approved these changes
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a topic has multiple partitions, the kafka-logger plugin creates a new producer instance to connect to kafka every time it pushes a message, which causes kafka to reallocate the partition each time, and all messages are placed in the same partition.
This PR reuse producer via lrucache to solve above problem.
fix #3384
Pre-submission checklist: