feat: add control api for discovery module #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The conflict needs to be solved so that the CI can run. |
spacewander
reviewed
Mar 4, 2021
| if discovery_type then | ||
| local discovery = require("apisix.discovery.init").discovery | ||
| local dump_apis = {} | ||
| for key, _ in pairs(discovery_type) do |
There was a problem hiding this comment.
It seems we can use for key, dis_mod in pairs(discovery) do directly?
There was a problem hiding this comment.
if use for key, dis_mod in pairs(discovery) do, the dis_mod is function type, not a table object.
So, we can't do it.
t/control/discovery.t
Outdated
| GET /v1/discovery/eureka/dump | ||
| --- error_code: 200 | ||
| --- response_body_unlike | ||
| ^{}$ |
|
The CI fails because of #3747 |
tokers
reviewed
Mar 4, 2021
docs/en/latest/discovery.md
Outdated
| @@ -92,6 +95,11 @@ Then implement the `_M.init_worker()` function for initialization and the `_M.no | |||
| end | |||
|
|
|||
|
|
|||
| function _M.dump_data() | |||
| ... ... | |||
There was a problem hiding this comment.
I think an example return data shoul be written here.
There was a problem hiding this comment.
for example ?
function _M.dump_data()
return {config = your_config, services = your_services, other = ... }
end
added 2 commits
March 5, 2021 13:31
spacewander
approved these changes
Mar 5, 2021
tokers
approved these changes
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Just implement the
_M.dump_data()function for discovery module, then call the control api for dumping running details online.The dump api uri template:
GET /v1/discovery/{discovery_type}/dumpeg:
Pre-submission checklist: