Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: remove deprecated upstream.enable_websocket #3854

Merged
merged 1 commit into from
Mar 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions apisix/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -401,12 +401,6 @@ function _M.http_access_phase()
end
end

if upstream.value.enable_websocket then
core.log.warn("DEPRECATE: enable websocket in upstream will be removed soon. ",
"Please enable it in route/service level.")
enable_websocket = true
end

if upstream.value.pass_host then
api_ctx.pass_host = upstream.value.pass_host
api_ctx.upstream_host = upstream.value.upstream_host
Expand Down
5 changes: 0 additions & 5 deletions apisix/schema_def.lua
Original file line number Diff line number Diff line change
Expand Up @@ -381,11 +381,6 @@ local upstream_schema = {
minLength = 1
},
id = id_schema,
-- deprecate fields, will be removed soon
enable_websocket = {
description = "enable websocket for request",
type = "boolean",
},
},
oneOf = {
{required = {"type", "nodes"}},
Expand Down