Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support passing different host headers in multiple nodes #4208

Merged
merged 1 commit into from
May 13, 2021
Merged

feat: support passing different host headers in multiple nodes #4208

merged 1 commit into from
May 13, 2021

Conversation

spacewander
Copy link
Member

Fix #2620
Fix #4197
Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
feat: support passing different host headers in multiple nodes
2c21115 
Fix apache#2620
Fix apache#4197
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review May 10, 2021 14:02
membphis
membphis reviewed May 10, 2021
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When starting the APISIX service instance, if the version is less than 1.19, a warning message will be printed to prompt the user to upgrade.

We can do this in the CLI

@spacewander
Copy link
Member Author

@membphis
We can do it in a separate PR

tokers
tokers reviewed May 13, 2021
View reviewed changes
apisix/balancer.lua Show resolved Hide resolved
apisix/init.lua Show resolved Hide resolved
@gxthrj gxthrj merged commit 045c351 into apache:master May 13, 2021
@elvis-cai elvis-cai mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis left review comments

@gxthrj gxthrj gxthrj approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@spacewander @gxthrj @membphis @tokers