Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(control): expose services #5271

Merged
merged 6 commits into from
Oct 20, 2021
Merged

feat(control): expose services #5271

merged 6 commits into from
Oct 20, 2021

Conversation

bisakhmondal
Copy link
Member

What this PR does / why we need it:

This PR exposes 2 control API routes for

  1. All services
  2. Service with a particular service_id

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@bisakhmondal
Copy link
Member Author

cc @spacewander for a review. Thanks : )

spacewander
spacewander reviewed Oct 19, 2021
View reviewed changes
t/control/services.t
=== TEST 1: services
--- apisix_yaml
services:
-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test with multiple services

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sounds good!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@spacewander spacewander changed the title feat: expose services via control API feat(control): expose services Oct 20, 2021
@spacewander spacewander merged commit e68e03f into apache:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bisakhmondal @spacewander @tzssangglass