feat(limit-count): support multiple variables as key #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokers
reviewed
Nov 2, 2021
|
cc @spacewander ,please take a look thanks. CI failed by other test case which is not related to limit-count |
spacewander
reviewed
Nov 2, 2021
moonming
reviewed
Nov 2, 2021
spacewander
approved these changes
Nov 2, 2021
tokers
approved these changes
Nov 3, 2021
Xunzhuo
commented
Nov 3, 2021
spacewander
reviewed
Nov 3, 2021
spacewander
reviewed
Nov 3, 2021
spacewander
approved these changes
Nov 3, 2021
spacewander
reviewed
Nov 4, 2021
spacewander
reviewed
Nov 4, 2021
| @@ -328,7 +328,7 @@ code: 200 | |||
| "limit-count": { | |||
| "count": ]] .. count .. [[, | |||
| "time_window": 60, | |||
| "key": "http_x_real_ip", | |||
| "key": "remote_addr", | |||
There was a problem hiding this comment.
Can we change the relative tests to use remote_addr too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feat(limit-count): support multiple variables as key
Pre-submission checklist: