Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing labels after merging route and service #6177

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fix: add missing labels after merging route and service #6177

merged 1 commit into from
Jan 21, 2022

Conversation

tzssangglass
Copy link
Member

Closes #6169

Signed-off-by: tzssangglass tzssangglass@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tzssangglass
fix: add missing labels after merging route and service
a5108d2 
Closes apache#6169

Signed-off-by: tzssangglass <tzssangglass@gmail.com>
@spacewander spacewander merged commit 800b890 into apache:master Jan 21, 2022
@tzssangglass tzssangglass deleted the IssueNo6169 branch January 24, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@starsz starsz starsz approved these changes

@zaunist zaunist zaunist approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: The custom labels will be lost when the route is associated with the service
5 participants
@tzssangglass @spacewander @starsz @zaunist @leslie-tsang