feat: rerun rewrite phase for newly added plugins in consumer

[tzssangglass]

Closes #6405

Signed-off-by: tzssangglass tzssangglass@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

• Did you explain what problem does this PR solve? Or what new features have been added?
• Have you added corresponding test cases?
• Have you modified the corresponding document?
• Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

[tzssangglass]

only call core.consumer.attach_consumer is considered to be an auth class plugin.

ref: #2898

[spacewander]

Maybe we can add a flag in

apisix/apisix/plugin.lua

Line 505 in c4229d1

new_route_conf.value.plugins[name] = conf

so that we can save allocation?

[tzssangglass]

update

[spacewander]

we can use if new_route_conf.value.plugins[name] == nil then conf._from_consumer = true?

[tzssangglass]

tried, Test 2 will fail. We need to merge the `new_route_conf.value.plugins["proxy-rewrite"], it will not be nil.

[spacewander]

What about this change?

diff --git apisix/plugin.lua apisix/plugin.lua
index d66ec045..190b0833 100644
--- apisix/plugin.lua
+++ apisix/plugin.lua
@@ -502,12 +502,11 @@ local function merge_consumer_route(route_conf, consumer_conf)
             new_route_conf.value.plugins = {}
         end

-        new_route_conf.value.plugins[name] = conf
-
-        if (route_conf and route_conf.value and route_conf.value.plugins)
-                and not route_conf.value.plugins[name] then
-            new_route_conf.value.plugins[name]["_from_consumer"] = true
+        if new_route_conf.value.plugins[name] == nil then
+            conf._from_consumer = true
         end
+
+        new_route_conf.value.plugins[name] = conf
     end

     core.log.info("merged conf : ", core.json.delay_encode(new_route_conf))

[tzssangglass]

yes, update

[spacewander]

Would be better to merge it in

apisix/apisix/plugin.lua

Line 736 in 492f782

if phase_func then

?

[tzssangglass]

I had thought about it, but if plugins[i + 1]["_from_consumer"] and plugins[i].type ~= "auth" then is difficult to port. Unless we add a flag or something like that. This makes run_plugin look even more complicated.

Another way is as follows:

    for i = 1, #plugins, 2 do
        -- no need to rerun the non-auth plugins
        if plugins[i + 1]["_from_consumer"] and plugins[i].type ~= "auth" then
            local new_plugins = core.table.new(2, 0)
            core.table.insert(new_plugins, plugins[i])
            core.table.insert(new_plugins, plugins[i + 1])
            _M.run_plugin("rewrite", new_plugins, api_ctx)
        end
    end
    return api_ctx

this adds some table overhead.

[tzssangglass]

The main reason is that the plugins here are used in the api_ctx in order to reduce the table overhead, so use the judgment condition.

[spacewander]

Maybe we can add another fake phase (rewrite_in_consumer) in run_plugin so we don't need to duplicate the conditions?

[tzssangglass]

update