Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary response body data check #6545

Merged
merged 9 commits into from
Mar 15, 2022

Conversation

Chever-John
Copy link
Contributor

@Chever-John Chever-John commented Mar 8, 2022

What this PR does / why we need it:

In the test file, there is a lot of redundant request response body data, and some just duplicate the input content. For this reason, a PR is needed to improve the test example situation.

Fix #6538

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Chever-John Chever-John changed the title docs: most have been removed docs: remove invalid response body data of test files Mar 8, 2022
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like we need to update:

ngx.status = code

to

if code >= 300 then
    ngx.status = code
end

Because the response data check will convert the status code to 200:

apisix/t/lib/test_admin.lua

Lines 204 to 214 in 9b0460f

if pattern == nil then
return res.status, "passed", res.body, res.headers
end
local res_data = json.decode(res.body)
local ok, err = _M.comp_tab(pattern, res_data)
if not ok then
return 500, "failed, " .. err, res_data
end
return 200, "passed", res_data, res.headers

@spacewander spacewander changed the title docs: remove invalid response body data of test files test: remove unnecessary response body data check Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: remove invalid response body data of test files
3 participants