Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workflow plugin(mvp) #7760

Merged
merged 6 commits into from
Aug 24, 2022
Merged

Conversation

tzssangglass
Copy link
Member

Description

I want to combine the existing DSL to support more complex limiting scenarios, this PR is just the first step in providing workflow plugins to implement basic orchestration capabilities.

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@tzssangglass tzssangglass marked this pull request as ready for review August 23, 2022 07:43
apisix/plugins/workflow.lua Outdated Show resolved Hide resolved
apisix/plugins/workflow.lua Outdated Show resolved Hide resolved
apisix/plugins/workflow.lua Show resolved Hide resolved
apisix/plugins/workflow.lua Outdated Show resolved Hide resolved
apisix/plugins/workflow.lua Outdated Show resolved Hide resolved


local function exit(conf)
local code = tonumber(conf.code)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is tonumber necessary after the schema check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need, fix it on next PR.

@spacewander spacewander merged commit 1cf96d1 into apache:master Aug 24, 2022
@tzssangglass tzssangglass deleted the workflow branch October 10, 2022 10:39
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants