-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka-logger): support sasl conf #7782
Closed
Closed
Changes from 3 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
40ddca3
feat(kafka-logger): support sasl conf
biubiue 21be757
feat(kafka-logger): doc add sasl conf
biubiue fad3df6
fix(kafka-logger): doc
biubiue de82ec3
feat(kafka-logger): test case
biubiue 33cd466
feat(kafka-logger): modify test case code style
biubiue 7e1db99
fix(kafka-logger): test case code style
biubiue ebeebc8
fix(kafka-logger): test case code style
biubiue cd68da2
fix(kafka-logger): test case code style
biubiue 0104c5a
fix(kafka-logger): test case code style
biubiue 503011c
Update kafka-logger.t
biubiue 18358aa
fix(kafka-logger): test case
biubiue 3812c9c
fix(kafka-logger): test case
biubiue c8baf35
Update kafka-logger.t
biubiue d348987
Update kafka-logger.t
biubiue 72f0d06
Update kafka-logger.t
biubiue 5b7dd8c
fix(kafka-logger): test case
biubiue 9f1817a
fix(kafka-logger): try other actions
biubiue 588bb0f
Update kafka-logger.t
biubiue 3a90b5d
Update kafka-logger.t
biubiue d10ea12
Update kafka-logger.t
biubiue 70054aa
Update kafka-logger.t
biubiue 35a581b
Update kafka-logger.t
biubiue 9d9f005
fix(kafka-logger): modify sasl_config properties
biubiue 8c41473
Update kafka-logger.md
biubiue 4e1cc34
Update kafka-logger.t
biubiue ddde433
Update kafka-logger.lua
biubiue 0444c00
Update kafka-logger.md
biubiue cc90a47
Update kafka-logger.lua
biubiue 290070c
fix(kafka-logger): test case
biubiue 1481240
fix(kafka-logger): test case
biubiue 6968d48
test case
biubiue 11d8dc6
test case
biubiue 8ca60db
test case
biubiue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,11 @@ It might take some time to receive the log data. It will be automatically sent a | |
| Name | Type | Required | Default | Valid values | Description | | ||
| ---------------------- | ------- | -------- | -------------- | --------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | ||
| broker_list | object | True | | | List of Kafka brokers (nodes). | | ||
| sasl_config | object | False | | | Kafka sasl conf. | | ||
| sasl_config.mechanism | string | False | | | Kafka mechanism. | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add the default value here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
ok |
||
| sasl_config.password | string | False | | | Kafka password. | | ||
| sasl_config.user | string | False | | | Kafka user. | | ||
| sasl_config.strategy | string | False | | | Kafka strategy. | | ||
| kafka_topic | string | True | | | Target topic to push the logs for organisation. | | ||
| producer_type | string | False | async | ["async", "sync"] | Message sending mode of the producer. | | ||
| required_acks | integer | False | 1 | [0, 1, -1] | Number of acknowledgements the leader needs to receive for the producer to consider the request complete. This controls the durability of the sent records. The attribute follows the same configuration as the Kafka `acks` attribute. See [Apache Kafka documentation](https://kafka.apache.org/documentation/#producerconfigs_acks) for more. | | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields should be required if the sasl config exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modify these fields ,and mark required fields