-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: remove backslash before slash when encoding #7807
Conversation
Is this a break change? |
Exactly, I can't guarantee it. The first time I encountered this kind of problem is when dealing with data in etcd((#7606)) . Then I found it was caused by lua-json and avoid it by turning off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test like
Line 132 in cffa4b6
=== TEST 6: decode/encode empty array |
There are some broken tests: I have checked them and all of them are about extra Would you please update the test cases? |
Yes, because the format of the json parsing has changed. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Description
Remove backslash before slash when setting routes to etcd or generating log to local files.
The backslash is from lua-cjson and it can be turned off by default.
https://github.com/openresty/lua-cjson/#encode_escape_forward_slash
Fixes (#7785)
Fixes (#7606)
Checklist