Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent failing to start because of the conf server sock #8022

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix: prevent failing to start because of the conf server sock #8022

merged 1 commit into from
Sep 30, 2022

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

Description

Fixes #7986

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@spacewander
fix: prevent failing to start because of the conf server sock
34fa788 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review September 29, 2022 13:07
@spacewander spacewander merged commit 68e3e0a into apache:master Sep 30, 2022
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@spacewander @Liu-Junlin
fix: prevent failing to start because of the conf server sock (apache…
9733947 
…#8022)
@spacewander spacewander mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokers tokers tokers approved these changes

@soulbird soulbird soulbird approved these changes

@starsz starsz starsz approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: should delete conf/config_listen.sock if start failed
5 participants
@spacewander @tokers @soulbird @starsz @tzssangglass