Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openid-connect): return userinfo when use_jwks is true #8347

Conversation

monkeyDluffy6017
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 commented Nov 17, 2022

Description

Return userinfo when use_jwks is true.
Add test case for pr #8135

Fixes #8133

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • [] I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

spacewander
spacewander previously approved these changes Nov 18, 2022
tzssangglass
tzssangglass previously approved these changes Nov 21, 2022
@tzssangglass
Copy link
Member

@monkeyDluffy6017 pls resolve conflicts

@monkeyDluffy6017
Copy link
Contributor Author

@tzssangglass Done

@spacewander spacewander merged commit 4346b0b into apache:master Nov 22, 2022
spacewander pushed a commit to spacewander/incubator-apisix that referenced this pull request Jan 28, 2023
Fixes apache#8133

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander pushed a commit that referenced this pull request Jan 30, 2023
Fixes #8133

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: plugin(openid-connect): when set use_jwks: true, userinfo is not set
3 participants