Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GM plugin EN doc to make website display normally #8393

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

SylviaBABY
Copy link
Member

@SylviaBABY SylviaBABY commented Nov 24, 2022

Description

In #8389, APISIX adds gm plugin feature and use guide. Because of the Docusaurus, this content will not be displayed when there are only Chinese documents, and there must be corresponding English version documents.
image

However, considering that this function only applies to the Chinese scene, to make the document display normally, the content in the English file is still in Chinese.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@SylviaBABY SylviaBABY marked this pull request as ready for review November 24, 2022 09:22
SkyeYoung
SkyeYoung previously approved these changes Nov 24, 2022
SkyeYoung
SkyeYoung previously approved these changes Nov 24, 2022
@spacewander
Copy link
Member

Please make the CI pass, thanks!

@SylviaBABY
Copy link
Member Author

Please make the CI pass, thanks!

Done. Thanks for @spacewander and @SkyeYoung to approve^^

@SylviaBABY SylviaBABY merged commit 7ffa264 into apache:master Nov 25, 2022
@SylviaBABY SylviaBABY deleted the add-gm-plugin-en-content branch November 25, 2022 03:13
hongbinhsu added a commit to fitphp/apix that referenced this pull request Dec 4, 2022
* upstream/master: (48 commits)
  fix(ai): remove BUILD_ROUTER event when ai module is unloaded (apache#8184)
  chore: add some comment for make_request_to_vault function (apache#8420)
  docs: update admin api English doc (apache#8227)
  ci: use fixed os version of ubuntu (apache#8438)
  feat: Support store secrets in secrets manager for auth plugin via kms components (apache#8421)
  feat: interact via gRPC in APISIX Admin API (apache#8411)
  fix: last_err can be nil when the reconnection is successful (apache#8377)
  feat: support global data encryption of secret information (apache#8403)
  refactor(env): rename funtion name (apache#8426)
  feat(admin): add kms admin api (apache#8394)
  docs: update consumer and upstream docs (apache#8223)
  ci: add cron job for GM (apache#8398)
  docs: add kms env doc (apache#8419)
  feat: Added log format support in syslog plugin. (apache#8279)
  feat: add vault common components (apache#8412)
  docs: update global-rule/plugin-config/plugin/ docs (apache#8262)
  docs: update consumer-group/router/service/script doc (apache#8332)
  feat: support store secret in env for auth plugin (apache#8390)
  docs: update Upgrade Guide CN version (apache#8392)
  docs: add GM plugin EN doc to make website display normally (apache#8393)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants