feat(prometheus): support collect metrics works in the priviledged agent #8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
membphis
reviewed
Dec 2, 2022
spacewander
reviewed
Dec 2, 2022
membphis
previously approved these changes
Dec 2, 2022
membphis
previously approved these changes
Dec 4, 2022
tokers
reviewed
Dec 5, 2022
spacewander
reviewed
Dec 5, 2022
apisix/cli/ngx_tpl.lua
Outdated
|
|
||
| init_by_lua_block { | ||
| require "resty.core" | ||
| apisix = require("apisix") |
There was a problem hiding this comment.
I double-checked this line and it seems the apisix is not used?
There was a problem hiding this comment.
remove it, and this helped me to solve the problem of repeatedly requiring apisix, thanks.
tokers
approved these changes
Dec 5, 2022
soulbird
approved these changes
Dec 6, 2022
membphis
approved these changes
Dec 6, 2022
spacewander
approved these changes
Dec 6, 2022
|
Can you fix this problem in version 2.15? The main reason is that we have been using the official Docker image deployment. It seems that we cannot directly repair it by copying files, but we need to compile the underlying modules. |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist