Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssl): ssl label upgrade max len #9301

Merged
merged 11 commits into from
May 5, 2023

Conversation

Fabriceli
Copy link
Contributor

Description

Upgrade SSL label len 64 to 256

Fixes # (issue)
apache/apisix-ingress-controller#1768

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

t/admin/ssl4.t Outdated Show resolved Hide resolved
@Fabriceli
Copy link
Contributor Author

could you return the CI? it seems that the unit test is not stable @monkeyDluffy6017

@Fabriceli
Copy link
Contributor Author

No error in my local for Code Lint CI:

$ make lint
[ info ] lint -> [ Start ]
./utils/check-lua-code-style.sh
+ luacheck -q apisix t/lib
Total: 0 warnings / 0 errors in 251 files
+ find apisix -name '*.lua' '!' -wholename apisix/cli/ngx_tpl.lua -exec ./utils/lj-releng '{}' +
+ grep -E 'ERROR.*.lua:' /tmp/check.log
+ true
+ '[' -s /tmp/error.log ']'
./utils/check-test-code-style.sh
+ find t -name '*.t' -exec grep -E '\-\-\-\s+(SKIP|ONLY|LAST|FIRST)$' '{}' +
+ true
+ '[' -s /tmp/error.log ']'
+ find t -name '*.t' -exec ./utils/reindex '{}' +
+ grep done. /tmp/check.log
+ true
+ '[' -s /tmp/error.log ']'
[ info ] lint -> [ Done ]

@monkeyDluffy6017
Copy link
Contributor

@Fabriceli Please fix the ci

@Fabriceli
Copy link
Contributor Author

@Fabriceli Please fix the ci

done

t/admin/ssl4.t Outdated Show resolved Hide resolved
@monkeyDluffy6017 monkeyDluffy6017 merged commit fc372af into apache:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants