Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http-logger): default request path should be '/' #9472

Merged
merged 2 commits into from
May 24, 2023

Conversation

jiangfucheng
Copy link
Member

Description

Fixes #9443

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@soulbird
Copy link
Contributor

@jiangfucheng
Copy link
Member Author

Look at this: https://github.com/api7/lua-resty-http/blob/master/t/13-default-path.t#L27, the default path is /

Thanks for you comment, I roughly took a look, the reqeust() method does not seem to cover this situation, it only covered by request_uri() method.

@monkeyDluffy6017 monkeyDluffy6017 merged commit 59b82e2 into apache:master May 24, 2023
AlinsRan pushed a commit to AlinsRan/apisix that referenced this pull request Jun 25, 2023
@jiangfucheng jiangfucheng deleted the http_logger branch August 6, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: http-logger plugin gives 400 error while pushing the logs to HTTP server
5 participants