Add set_bits fuzz test
#6394
Merged
Add set_bits fuzz test
#6394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Sep 13, 2024
| self.write_data | ||
| .resize(offset_write_bytes + len + extra_write_data_bytes, 0); | ||
|
|
||
| // interestingly set_bits seems to assume the output is already zeroed |
There was a problem hiding this comment.
I was surprised at this -- if we fill the target with random data the tests fail (I am not sure why)
alamb
commented
Sep 13, 2024
| self.expected_data.resize(self.write_data.len(), 0); | ||
| self.expected_data.copy_from_slice(&self.write_data); | ||
|
|
||
| self.expected_null_count = 0; |
There was a problem hiding this comment.
The fuzz tester runs this code to compute the expected output (using set_bit and get_bit)
alamb
force-pushed
the
alamb/set_bits_fuzz
branch
from
d77e4c0
to
074e0f8
Compare
alamb
commented
Sep 13, 2024
alamb
commented
Sep 13, 2024
kazuyukitanimura
approved these changes
Sep 14, 2024
Dandandan
approved these changes
Sep 20, 2024
|
Thank you @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6288
Rationale for this change
The code in #6288 is tricky and includes many special cases and
unsafeso extra testing is warrantedWhat changes are included in this PR?
Refactor the tests for
set_bitsinto a struct and then implement a fuzzer that randomly generates test casesAre there any user-facing changes?
No, this is entirely testing