fix: don't panic in IPC reader if struct child arrays have different lengths #6417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any advice on how to generate this type of invalid batch with arrow-rs for testing? |
alamb
reviewed
Sep 18, 2024
arrow-ipc/src/reader.rs
Outdated
| @@ -31,7 +31,9 @@ use std::io::{BufReader, Read, Seek, SeekFrom}; | |||
| use std::sync::Arc; | |||
|
|
|||
| use arrow_array::*; | |||
| use arrow_buffer::{ArrowNativeType, BooleanBuffer, Buffer, MutableBuffer, ScalarBuffer}; | |||
| use arrow_buffer::{ | |||
There was a problem hiding this comment.
Can we please get a test for this fix so that we don't break it again during some future refactoring?
There was a problem hiding this comment.
just added, was able to write the invalid array to ipc buffer using ArrayDataBuilder::build_unchecked
alamb
reviewed
Sep 18, 2024
alamb
approved these changes
Sep 20, 2024
| @@ -2235,4 +2237,50 @@ mod tests { | |||
|
|
|||
| assert_eq!(batch, roundtrip_batch); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_invalid_struct_array_ipc_read_errors() { | |||
There was a problem hiding this comment.
I verified that this test panic's without the code changes in this PR, as expected
` value: InvalidArgumentError("Incorrect array length for StructArray field \"b\", expected 4 got 3")
stack backtrace:
0: rust_begin_unwind
at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:665:5
1: core::panicking::panic_fmt
at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:74:14
2: core::result::unwrap_failed
at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/result.rs:1679:5
3: core::result::Result<T,E>::unwrap
at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/result.rs:1102:23
4: arrow_array::array::struct_array::StructArray::new
at /Users/andrewlamb/Software/arrow-rs/arrow-array/src/array/struct_array.rs:90:9
5: <arrow_array::array::struct_array::StructArray as core::convert::From<alloc::vec::Vec<(alloc::sync::Arc<arrow_schema::field::Field>,alloc::sync::Arc<dyn arrow_array::array::Array>)>>>::from
at /Users/andrewlamb/Software/arrow-rs/arrow-array/src/array/struct_array.rs:401:9
6: arrow_ipc::reader::create_array
at ./src/reader.rs:167:17
7: arrow_ipc::reader::read_record_batch_impl
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6416
Rationale for this change
While we don't expect to receive invalid IPC data via flight. We would like to avoid panics if possible.
What changes are included in this PR?
Use StructArray::try_new vs StructArray::from in ipc reader. StructArray::from impls use StructArray::new. new calls try_new but unwraps.
Are there any user-facing changes?
No