Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parquet: enable base64 if needed #812

Closed
wants to merge 1 commit into from
Closed

parquet: enable base64 if needed #812

wants to merge 1 commit into from

Conversation

taralx
Copy link

@taralx taralx commented Oct 1, 2021

Closes #811.

@taralx taralx changed the title parquet: only enable base64 if needed parquet: enable base64 if needed Oct 1, 2021
@github-actions github-actions bot added the parquet Changes to the parquet crate label Oct 1, 2021
alamb
alamb previously approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taralx ! If this passes CI looks good to me.

@alamb alamb dismissed their stale review October 6, 2021 11:06

CI is failing

@taralx
Copy link
Author

taralx commented Oct 6, 2021

Curses. Requires rust-lang/cargo#5565 to hit stable first.

@taralx taralx closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb left review comments

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parquet allows use of arrow without base64
2 participants
@taralx @alamb