Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring status check failed #10534

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Sep 2, 2022

Signed-off-by: crazyhzm crazyhzm@gmail.com

What is the purpose of the change

Brief changelog

Verifying this change

stack:

Caused by: java.lang.UnsupportedOperationException: GenericWebApplicationContext does not support getConfigLocations()
        at org.springframework.web.context.support.GenericWebApplicationContext.getConfigLocations(GenericWebApplicationContext.java:270)
        ... 41 more

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@CrazyHZM CrazyHZM added this to the 3.1.1 milestone Sep 2, 2022
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #10534 (d8bb787) into 3.1 (db210e0) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                3.1   #10534      +/-   ##
============================================
+ Coverage     64.57%   64.62%   +0.04%     
  Complexity      396      396              
============================================
  Files          1331     1331              
  Lines         56548    56509      -39     
  Branches       8370     8369       -1     
============================================
+ Hits          36517    36519       +2     
+ Misses        16084    16042      -42     
- Partials       3947     3948       +1     
Impacted Files Coverage Δ
...ubbo/config/spring/status/SpringStatusChecker.java 55.00% <0.00%> (ø)
...dubbo/remoting/zookeeper/ZookeeperTransporter.java 50.00% <0.00%> (-33.34%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 43.86% <0.00%> (-26.42%) ⬇️
...he/dubbo/rpc/listener/ListenerExporterWrapper.java 68.00% <0.00%> (-20.00%) ⬇️
...bbo/common/resource/GlobalResourcesRepository.java 63.07% <0.00%> (-7.84%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-6.90%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 66.97% <0.00%> (-3.67%) ⬇️
...ubbo/common/url/component/param/DynamicValues.java 78.12% <0.00%> (-3.13%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.09% <0.00%> (-2.39%) ⬇️
...registry/zookeeper/util/CuratorFrameworkUtils.java 72.22% <0.00%> (-2.23%) ⬇️
... and 39 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit bb7f942 into apache:3.1 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants