Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faq建设 #10536

Merged
merged 1 commit into from
Sep 3, 2022
Merged

faq建设 #10536

merged 1 commit into from
Sep 3, 2022

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented Sep 2, 2022

FailbackClusterInvoker类错误码改造。

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

faq-FailbackClusterInvoker
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #10536 (517a79e) into 3.1 (bb7f942) will decrease coverage by 0.11%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##                3.1   #10536      +/-   ##
============================================
- Coverage     64.74%   64.63%   -0.12%     
- Complexity      373      395      +22     
============================================
  Files          1331     1331              
  Lines         56509    56509              
  Branches       8369     8370       +1     
============================================
- Hits          36587    36524      -63     
- Misses        15978    16023      +45     
- Partials       3944     3962      +18     
Impacted Files Coverage Δ
...bo/rpc/cluster/support/FailbackClusterInvoker.java 78.46% <83.33%> (ø)
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 64.28% <0.00%> (-14.29%) ⬇️
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 58.33% <0.00%> (-8.34%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.17% <0.00%> (-7.76%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) ⬇️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 84.84% <0.00%> (-6.07%) ⬇️
...ubbo/common/system/OperatingSystemBeanManager.java 50.00% <0.00%> (-4.55%) ⬇️
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit ef14458 into apache:3.1 Sep 3, 2022
@AlbumenJ AlbumenJ mentioned this pull request Sep 8, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants