Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract compareTo impl to Router interface and concrete Router only responsible for provide priority. #3240

Merged
merged 6 commits into from
Jan 16, 2019
Merged

Extract compareTo impl to Router interface and concrete Router only responsible for provide priority. #3240

merged 6 commits into from
Jan 16, 2019

Commits on Jan 16, 2019

  1. extract compareTo impl to Router interface and concrete Router only p… 

    …rovide priority
    @chickenlj
    chickenlj committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    133fd5c View commit details
    Browse the repository at this point in the history

  2. add override CompareTo back to compatible Router and add UT

    @chickenlj
    chickenlj committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    9c2c60d View commit details
    Browse the repository at this point in the history

  3. Fix compareTo in compatible Router

    @chickenlj
    chickenlj committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    bf4800b View commit details
    Browse the repository at this point in the history

  4. Fix possible NPE in Router

    @chickenlj
    chickenlj committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    82c1bcc View commit details
    Browse the repository at this point in the history

  5. Fix possible NPE in Router

    @chickenlj
    chickenlj committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    d154e11 View commit details
    Browse the repository at this point in the history

  6. Change router order in case of getUrl empty

    @chickenlj
    chickenlj committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    f65530c View commit details
    Browse the repository at this point in the history