Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35872][table] Fix the incorrect partition generation during period refresh in Full Mode #25108

Closed
wants to merge 2 commits into from
Closed

[FLINK-35872][table] Fix the incorrect partition generation during period refresh in Full Mode #25108

wants to merge 2 commits into from

Conversation

hackergin
Copy link
Contributor

What is the purpose of the change

Fix the incorrect partition generation during period refresh in Full Mode

Brief change log

  • Fix the incorrect partition generation during period refresh in Full Mode

Verifying this change

  • Add some test case in MaterializedTableManagerTest#testGetPeriodRefreshPartition to verify the change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 21, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

lsyldliu
lsyldliu reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I left some comments.

...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java Outdated Show resolved Hide resolved
...y/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java Show resolved Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java Show resolved Hide resolved
...a/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManagerTest.java Show resolved Hide resolved
...a/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManagerTest.java Show resolved Hide resolved
...a/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManagerTest.java Outdated Show resolved Hide resolved
@hackergin
Copy link
Contributor Author

@lsyldliu Thank you for reviewing. I have addressed the related comments; please have a look

lsyldliu
lsyldliu approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsyldliu lsyldliu closed this in af7d2b3 Jul 22, 2024
lsyldliu pushed a commit that referenced this pull request Jul 23, 2024
@hackergin @lsyldliu
[FLINK-35872][table] Fix the incorrect partition generation for mater…
a326854 
…ialized table period refresh in Full Mode

This closes #25108

(cherry picked from commit af7d2b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsyldliu lsyldliu lsyldliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hackergin @flinkbot @lsyldliu