GEODE-3923 Document the 2 new properties serializable-object-filter #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and validate-serializable-objects
karensmolermiller
requested review from
bschuchardt,
davebarnes97 and
joeymcallister
davebarnes97
approved these changes
Dec 14, 2017
bschuchardt
reviewed
Dec 14, 2017
| @@ -753,6 +760,12 @@ See <a href="../../developing/distributed_regions/how_region_versioning_works.ht | |||
| <td>S</td> | |||
| <td><em>not set</em></td> | |||
| </tr> | |||
| <tr class="even"> | |||
| <td>validate-serializable-objects</td> | |||
| <td>A boolean that defaults to false. When true, all internal <%=vars.product_name%> classes and the objects defined by the property serializable-object-filter will be serialized. An <code>IncompatibleClassException</code> is thrown for objects not listed. JDK 8 build 121 or a later build must be installed to use this property. Servers and clients that do not meet this requirement will throw an exception upon startup.</td> | |||
There was a problem hiding this comment.
I think this should say "instances of classes that are not internal to <%=vars.product_name%> and whose class name is not allowed by the serializable-object-filter will not be permitted to be deserialized."
The property controls what is allowed to be deserialized, not what is allowed to be serialized.
joeymcallister
approved these changes
Dec 15, 2017
PivotalSarge
pushed a commit
to upthewaterspout/geode
that referenced
this pull request
Dec 15, 2017
…pache#1166) * GEODE-3923 Document the 2 new properties serializable-object-filter and validate-serializable-objects * GEODE-3923 Revise validate-serializable-objects property defn
PurelyApplied
pushed a commit
to PurelyApplied/geode
that referenced
this pull request
Dec 18, 2017
…pache#1166) * GEODE-3923 Document the 2 new properties serializable-object-filter and validate-serializable-objects * GEODE-3923 Revise validate-serializable-objects property defn
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.