Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROOVY-11443: Support multiple Requires/Ensures/Invariant annotations… #2100

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

paulk-asert
Copy link
Contributor

… in groovy-contracts

@paulk-asert
Copy link
Contributor Author

paulk-asert commented Jul 17, 2024

I still have some tests to write but manual testing seems to work as expected.
Update: Initial tests complete.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 92.62295% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.6531%. Comparing base (6cd477b) to head (6725458).
Report is 184 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2100        +/-   ##
==================================================
+ Coverage     68.5957%   68.6531%   +0.0574%     
- Complexity      29233      29387       +154     
==================================================
  Files            1426       1426                
  Lines          113494     113635       +141     
  Branches        19548      19596        +48     
==================================================
+ Hits            77852      78014       +162     
+ Misses          29088      29067        -21     
  Partials         6554       6554                
Files Coverage Δ
...va/org/codehaus/groovy/ast/tools/GeneralUtils.java 85.6132% <100.0000%> (+1.0699%) ⬆️
.../ClosureExpressionEvaluationASTTransformation.java 95.8333% <100.0000%> (+0.3788%) ⬆️
...ontracts/ast/visitor/AnnotationClosureVisitor.java 90.9483% <100.0000%> (ø)
...ache/groovy/contracts/ast/visitor/BaseVisitor.java 85.7143% <ø> (ø)
.../contracts/classgen/asm/ContractClosureWriter.java 86.3014% <100.0000%> (ø)
...tracts/common/impl/EnsuresAnnotationProcessor.java 66.6667% <100.0000%> (ø)
...ntracts/common/impl/lc/PostconditionLifecycle.java 92.8571% <100.0000%> (-0.4762%) ⬇️
...racts/common/spi/ProcessingContextInformation.java 56.6667% <100.0000%> (ø)
...g/apache/groovy/contracts/domain/AssertionMap.java 100.0000% <100.0000%> (ø)
...apache/groovy/contracts/domain/ClassInvariant.java 60.0000% <100.0000%> (ø)
... and 15 more

... and 46 files with indirect coverage changes

@daniellansun
Copy link
Contributor

+1

@paulk-asert paulk-asert merged commit f8e2f9e into apache:master Jul 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants