GROOVY-11459: MD5 is already an insecure hash algorithm, replacing it with SHA256 i…

[zhangwei911]

https://issues.apache.org/jira/browse/GROOVY-11459

[paulk-asert]

Thanks for your contributions to this topic. I did a little bit more performance testing and think this topic deserves more discussion. I'll add some results into the corresponding Jira issue and create an email on the dev list shortly. We'll likely make some changes similar to what you are suggesting but some assumptions about algorithm speed weren't as I expected.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.6751%. Comparing base (6cd477b) to head (aed169b).
Report is 238 commits behind head on master.

Files with missing lines	Patch %	Lines
src/main/java/groovy/lang/GroovyClassLoader.java	42.8571%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##               master      #2112        +/-   ##
==================================================
+ Coverage     68.5957%   68.6751%   +0.0794%     
- Complexity      29233      29404       +171     
==================================================
  Files            1426       1426                
  Lines          113494     113635       +141     
  Branches        19548      19599        +51     
==================================================
+ Hits            77852      78039       +187     
+ Misses          29088      29048        -40     
+ Partials         6554       6548         -6     

Files with missing lines	Coverage Δ
src/main/java/groovy/lang/GroovyClassLoader.java	71.0456% <42.8571%> (-0.4613%)	⬇️

... and 53 files with indirect coverage changes

[paulk-asert]

I'll merge and refactor to be halfway between your suggestion and what I have been doing for testing. Thanks!

[zhangwei911]

Thank you very much for doing these tests, and I am very glad that this has been adopted.

…

---- Replied Message ---- | From | Paul ***@***.***> | | Date | 09/12/2024 14:05 | | To | ***@***.***> | | Cc | ***@***.***>***@***.***> | | Subject | Re: [apache/groovy] GROOVY-11459: MD5 is already an insecure hash algorithm, replacing it with SHA256 i… (PR #2112) | I'll merge and refactor to be halfway between your suggestion and what I have been doing for testing. Thanks! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>