GUACAMOLE-1866: Allow recent connections to be removed. #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuehlner
reviewed
Apr 12, 2024
guacamole/src/main/frontend/src/app/history/services/guacHistory.js
Outdated
Show resolved
Hide resolved
jmuehlner
reviewed
Apr 12, 2024
jmuehlner
reviewed
Apr 17, 2024
jmuehlner
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an additional change to the "Recent Connections" functionality that allows for a connection to be removed from the list. A small red "X" is added to the upper-right corner of the connection thumbnail, as shown in the image below, and, when clicked, the connection will be removed.
It's worth noting that I had some trouble positioning the "X" exactly where I wanted it (directly over the thumbnail image), while still allowing the click functionality to work correctly. If anyone has suggestions on how to update the CSS to position, but allow it to work, I'm open to suggestions. The main challenge was that I cannot place the
<div></div>tags that contain the image inside of the<a></a>tags, so positioning over the<img>was a bit challenging.