-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUACAMOLE-1881: Add parameter token containing the domain of LDAP/AD usernames. #987
GUACAMOLE-1881: Add parameter token containing the domain of LDAP/AD usernames. #987
Conversation
…rom user credentials
…to derive static name.
20e7033
to
c330dbb
Compare
...le-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Show resolved
Hide resolved
...le-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Outdated
Show resolved
Hide resolved
...le-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Show resolved
Hide resolved
@mike-jumper Can we get these changes into next release, its been months since I have raise pull request. |
@mike-jumper any plans to look into this pull request? it's been more than 6 months. |
@josnabattula Are you able to see Nick's comments above? |
I can see. But those comments are on your branch you have refactored after my commit cheery-picked. I am thinking you are going to resolve it. |
Oof, right - that was silly of me. Sorry about that, @josnabattula. |
… domain is used for a token.
c330dbb
to
37d8e5a
Compare
@necouchman Could you review again? All review comments are resolved now. thanks. |
This change is intended to supersede the changes proposed by poor @josnabattula via PR #931 that I have been very slow to review. It builds off the original commit (27bbd35) by:
TokenName.canonicalize()
(there's no need to dynamically derive the token name of a static value).getDomainToken()
renamed and redocumented asgetUserDomain()
).Pattern
(there's no need to repeatedly recompile the regex each time a user logs in - it never changes).