GUACAMOLE-1267: Add VNC setting 'disable-server-input' #327
Conversation
stefan-esq
force-pushed
the
GUACAMOLE-1267
branch
2 times, most recently
from
8ae47f9
to
75cd1ae
Compare
stefan-esq
changed the title
stefan-esq
force-pushed
the
GUACAMOLE-1267
branch
from
75cd1ae
to
18bc44a
Compare
| msg.pad = 0; | ||
|
|
||
| rfbBool success = WriteToRFBServer(rfb_client, (char*)&msg, sz_rfbSetServerInputMsg); | ||
| guac_client_log(client, GUAC_LOG_DEBUG, "%s send request to disable server input", success ? "Successfully" : "Failed to"); |
There was a problem hiding this comment.
This reads well in the case of failure ("Failed to send request ..."), but the grammar gets wonky if things are sent successfully ("Successfully send request ...").
Perhaps it would be better to simply have two separate guac_client_log() calls? That would also allow for the failure case to be logged at a higher log level like GUAC_LOG_WARNING without getting too cluttered.
| rfbSetServerInputMsg msg; | ||
| msg.type = rfbSetServerInput; | ||
| msg.status = 1; | ||
| msg.pad = 0; |
There was a problem hiding this comment.
FYI - I'm sure this is fine as-is (all structure members are explicitly initialized here), but you can do this quickly and cleanly in one step with:
rfbSetServerInputMsg msg = {
.type = rfbSetServerInput,
.status = 1
};with pad implicitly zeroed.
I'm OK with things as you have them, but just wanted to point the above out. We have additional syntax at our disposal here thanks to the codebase being written for C99.
|
@stefan-esq : Any chance you could finish this up and we can get this merged? |
Add a new VNC setting 'disable-remote-input' which attempts to turn the remote input off when set to true.