Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use notifier::RequestNotifiers instead of dedup_requests::RequestNotifiers #1249

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Oct 9, 2023

Rationale

Now, there are same code of RequestNotifiers in notifier and dedup_requests, so we can use notifier::RequestNotifiers instead of dedup_requests::RequestNotifiers

Detailed Changes

  • use notifier::RequestNotifiers instead of dedup_requests::RequestNotifiers
  • remove dedup_requests file

Test Plan

Existing tests

server/src/server.rs Outdated Show resolved Hide resolved
@ShiKaiWi ShiKaiWi merged commit 2241cb9 into apache:main Oct 20, 2023
7 checks passed
@baojinri baojinri deleted the refactor-dedup-request branch December 5, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants