Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve error readability #1265

Merged
merged 1 commit into from
Oct 18, 2023
Merged

refactor: improve error readability #1265

merged 1 commit into from
Oct 18, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Oct 17, 2023 •
edited
Loading

Rationale

Currently when there are errors, sql is in the middle of err message, the most important message is in the last, when sql is too long, it's hard to find real root cause.

Detailed Changes

  • Put sql in the last part of error message
  • Remove failed log, use slow_log instead.

Test Plan

Integration tests.

ShiKaiWi
ShiKaiWi approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit a1f76b7 into apache:main Oct 18, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the feat-improve-errmsg branch October 18, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @ShiKaiWi