Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update create table integration test result #1344

Merged
merged 2 commits into from
Dec 7, 2023
Merged

chore: update create table integration test result #1344

merged 2 commits into from
Dec 7, 2023

Conversation

ZuLiangWang
Copy link
Contributor

@ZuLiangWang ZuLiangWang commented Dec 5, 2023

Rationale

Because the logic related to create table has been reconstructed in horaemeta apache/incubator-horaedb-meta#288, the results returned when reporting errors during create table have changed. Therefore, we need to correct the results of table creation in the integration test.

Detailed Changes

  • Update create table result in integration test.

Test Plan

No need.

@ZuLiangWang ZuLiangWang changed the base branch from main to dev December 5, 2023 12:00
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 9f9079f into apache:dev Dec 7, 2023
5 of 7 checks passed
ZuLiangWang added a commit that referenced this pull request Dec 7, 2023
## Rationale
In this PR #1344, the results of
table creation in the integration test were updated, but it was found
that the integration test failed to pass due to an extra blank row. Fix
this problem.

## Detailed Changes
* Fix create table result.

## Test Plan
No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants