Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block rules support query #1420

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jan 3, 2024

Rationale

Query with long time range usually cost too much resources, which affect stable of the whole cluster

Detailed Changes

  • Support block query by query range

Test Plan

Manually

curl 0:5000/admin/block -H 'content-type: application/json' -d '
{
  "operation": "Set",
  "write_block_list": [],
  "read_block_list": [],
  "block_rules": [
    {"type": "QueryRange", "content": "24h"}
  ]
}'

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 904e2d5 into apache:dev Jan 4, 2024
6 checks passed
@jiacai2050 jiacai2050 deleted the feat-block-by-range branch January 4, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants