refactor: coderr package #1504
Open
refactor: coderr package #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Mar 22, 2024
| @@ -95,7 +95,7 @@ func main() { | |||
| panicf("fail to init global logger, err:%v", err) | |||
| } | |||
| defer logger.Sync() //nolint:errcheck | |||
| log.Info(fmt.Sprintf("server start with version: %s", buildVersion())) | |||
| log.Info(fmt.Sprintf("server start with version:%s", buildVersion())) | |||
There was a problem hiding this comment.
Suggested change
| log.Info(fmt.Sprintf("server start with version:%s", buildVersion())) | |
| log.Info("Start server", zap.String("version", buildVersion())) |
| errMsg := fmt.Sprintf(format, a...) | ||
| causeWithStack := errors.WithStack(errors.New(errMsg)) | ||
| causeWithStack := errors.WithStack(errors.New("")) |
There was a problem hiding this comment.
IMO, this function should not add stack, users can use WithCausef to do this. Otherwise this function is same with WithCausef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #1501
Current coderr package's usage is complex and confusing.
Detailed Changes
CodeErrorDefwhich is made different from theCodeErrorTest Plan
Pass the existing CI.