feat: support horaedb submit compaction task to remote #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Rachelint
reviewed
Sep 5, 2024
LeslieKid
force-pushed
the
remote-compactor
branch
from
5fe7bce
to
1c98627
Compare
4 tasks
Rachelint
reviewed
Sep 13, 2024
Rachelint
reviewed
Sep 14, 2024
Rachelint
reviewed
Sep 14, 2024
| use snafu::{Snafu, ResultExt}; | ||
|
|
||
| #[async_trait] | ||
| pub trait RemoteCompactionNodePicker: Send + Sync { |
There was a problem hiding this comment.
We can impl a simple local picker initialized from conifg for easy testing.
LeslieKid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The subtask to support compaction offloading. See #1545
Detailed Changes
Compaction node support remote compaction service
Define
CompactionServiceImplto support compaction rpc service.Introduce
NodeTypeto distinguish compaction node and horaedb node. Enable the deployment of compaction node.Impl
compaction_clientfor horaedb node to access remote compaction node.Horaedb node support compaction offload
compaction_offloadin analytic engine'sConfigto determine whether exec compaction offload or not.RemoteCompactionNodePickertrait, supporting get remote compaction node info.RemoteCompactionRunner, supporting pick remote node and pass compaction task to the node.example-cluster-n.toml) to explain how to deploy a cluster supporting compaction offload.Test Plan
TODO