Skip to content

Commit

Permalink
Feedback on PR
Browse files Browse the repository at this point in the history
  • Loading branch information
Fokko Driesprong committed Mar 9, 2022
1 parent f8e75bc commit bfceb0e
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 46 deletions.
10 changes: 10 additions & 0 deletions python/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ package_dir =
= src
packages = find:
python_requires = >=3.7
install_requires =
pytz
retrying
mmh3
fastavro>=1.3.2<1.4.0
hmsclient==0.1.1
boto3
pyarrow
[options.extras_require]
dev = tox-travis==0.12; pytest

[options.packages.find]
where = src
36 changes: 0 additions & 36 deletions python/setup.py

This file was deleted.

4 changes: 1 addition & 3 deletions python/src/iceberg/expressions.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from enum import Enum, auto


Expand Down Expand Up @@ -54,7 +52,7 @@ class Operation(Enum):
AND = auto()
OR = auto()

def negate(self) -> Operation:
def negate(self) -> "Operation":
"""Returns the operation used when this is negated."""

try:
Expand Down
13 changes: 6 additions & 7 deletions python/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ deps =
mock
pytest
pytest-checkdocs
pyarrow
setenv =
COVERAGE_FILE = test-reports/{envname}/.coverage
PYTEST_ADDOPTS = --junitxml=test-reports/{envname}/junit.xml -vv
Expand All @@ -51,17 +50,17 @@ deps =
isort
autoflake
commands =
autoflake -r --check --ignore-init-module-imports --remove-all-unused-imports setup.py src tests
isort --profile black --check-only setup.py src tests
black --line-length 130 --check --diff setup.py src tests
autoflake -r --check --ignore-init-module-imports --remove-all-unused-imports src tests
isort --profile black --check-only src tests
black --line-length 130 --check --diff src tests

[testenv:format]
deps =
{[testenv:format-check]deps}
commands =
autoflake -r --in-place --ignore-init-module-imports --remove-all-unused-imports setup.py src tests
isort --profile black setup.py src tests
black --line-length 130 setup.py src tests
autoflake -r --in-place --ignore-init-module-imports --remove-all-unused-imports src tests
isort --profile black src tests
black --line-length 130 src tests

[testenv:type-check]
deps =
Expand Down

0 comments on commit bfceb0e

Please sign in to comment.