Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 1.55 nightly #349

Closed
wants to merge 1 commit into from
Closed

Upgrade to 1.55 nightly #349

wants to merge 1 commit into from

Conversation

celaus
Copy link

@celaus celaus commented Aug 4, 2021

Hi! We needed to use a compiler > 1.50 for adding new dependencies that rely on const generics. Since std::raw has been removed in current nightly versions (and it's not entirely clear to me where it's used in the SGX SDK) this compiler upgrade should be safe to make. All the sample code compiles and I could manually run several of them inside the 18.04 container.

For anyone also using 3rd party ports of libraries to this SGX SDK (because they won't build with the new compiler version out of the box), use this in your Cargo.toml (upgrade later to this - official - repo):

[patch.'https://github.com/apache/teaclave-sgx-sdk.git']
sgx_align_struct_attribute = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_alloc = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_backtrace = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_backtrace_sys = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_build_helper = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_cov = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_crypto_helper = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_demangle = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_libc = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_no_tstd = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_rand = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_rand_derive = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_serialize = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_serialize_derive = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_serialize_derive_internals = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tcrypto = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tcrypto_helper = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tdh = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tkey_exchange = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tprotected_fs = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_trts = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tse = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tseal = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tstd = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_tunittest = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_types = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_ucrypto = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_unwind = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }
sgx_urts = { git = "https://github.com/celaus/incubator-teaclave-sgx-sdk" }

Don't forget to cargo update

Somewhat fixes #315

@celaus celaus mentioned this pull request Aug 4, 2021
@xu-cheng
Copy link
Contributor

@volcano0dr @dingelish Any chance to merge this?

@volcano0dr
Copy link
Contributor

@celaus @xu-cheng
I plan to upgrade the rust toolchain on the v1.1.4-testing branch soon.

@xu-cheng
Copy link
Contributor

xu-cheng commented Sep 3, 2021

Hi, sorry to ping again. But any chance to move this forward?

Noted that Rust 2021 edition is about to be stabilize in Rust 1.56, which will be in beta in a week. We should really upgrade the support rust version of this SDK. Otherwise, it is likely that many crates will stop compiling if they are upgrading to 2021 edition.

@mssun
Copy link
Member

mssun commented Sep 13, 2021

I think this should be properly resolved as soon as possible.

@volcano0dr any timeline for the new version?

@PiDelport
Copy link
Contributor

The v1.1.4-testing branch was merged, with toolchain nightly-2021-09-13 (rustc 1.57.0-nightly).

@volcano0dr volcano0dr closed this Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stable rust?
5 participants