Replace "skip-duplicate-action" GHA jobs pre-check with native GHA concurrency functionality #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed the change works as expected (https://github.com/apache/libcloud/actions/runs/5725752694?pr=1924), so I will go ahead and implement it for all the workflows. |
"concurrency" functionality. Concurrency functionality which allows us to cancel redundant builds is now available natively as part of GHA functionality so we can get rid of skip duplicate actions action and simplify the workflow. This way we can also get rid of write permission which was needed by that action to be able to cancel in progress GHA job runs.
Kami
force-pushed
the
switch_concurrency
branch
from
471dc02
to
e15e234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates all the workflows and switches from
skip-duplicate-actionsGHA action to native "concurrency" functionality.Ability to cancel old and redundant builds is now part of native GHA functionality. Utilizing native functionality allows us to simplify the workflows and remove that
pre_jobcheck. It also allows us to get rid of additional write permission which was required by that action.