Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automate version bumps #181

Merged
merged 4 commits into from
Sep 16, 2024
Merged

automate version bumps #181

merged 4 commits into from
Sep 16, 2024

Conversation

FreeAndNil
Copy link
Contributor

Update the log4net version in every relevant file via script

@FreeAndNil FreeAndNil added this to the 3.1.0 milestone Sep 16, 2024
fluffynuts
fluffynuts approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@fluffynuts fluffynuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though I'd suggest that we find a way to not have to hardcode the new version into the script, ie provide a parameter or something like that. But this is still a vast improvement.

@FreeAndNil
Copy link
Contributor Author

@fluffynuts they were already parameters, I just added default values for easier debugging.
I've removed the default values. Thanks for the hint.

@FreeAndNil FreeAndNil merged commit fd4703e into master Sep 16, 2024
@FreeAndNil FreeAndNil deleted the Feature/181-automate-version-bumps branch September 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffynuts fluffynuts fluffynuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@FreeAndNil @fluffynuts