Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-437][MRESOLVER-438] Do not force set Expect-Continue setting #373

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 20, 2023

But allow users to override default (that comes from transport being in use). Also, ignore this setting on Java versions below 20. Finally, align class names for jdk transport as they were inconsistent.


https://issues.apache.org/jira/browse/MRESOLVER-437
https://issues.apache.org/jira/browse/MRESOLVER-438

But allow users to override defailt (that comes from
transport being in use).

---

https://issues.apache.org/jira/browse/MRESOLVER-437
@cstamas cstamas self-assigned this Nov 20, 2023
@cstamas cstamas changed the title [MRESOLVER-437] Do not force set Expect-Continue setting [MRESOLVER-437][MRESOLVER-438] Do not force set Expect-Continue setting Nov 20, 2023
Copy link
Contributor

@rmannibucau rmannibucau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small side note (not blocking)

side note: think default http version should be 1.1 (until we enhance our protocol to use it somehow) cause http 2 has several issues (a lot of servers and some which can impact clients). Boost is not that huge once keep alive is on for us so let's not abuse it in our defaults?

PS: thanks for the hyphen typo fix ;)

@cstamas cstamas merged commit a70ddef into apache:master Nov 20, 2023
4 checks passed
@cstamas cstamas deleted the MRESOLVER-437 branch November 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants