Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOLVER-547] Just use setVersion #483

Merged

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Apr 25, 2024

No need for full copy, Artifact is already immutable. Moreover, the instance may be not DefaultArtifact but something else. And finally, setVersion already
have "optimization" to return this if version is
same as the one we want to copy with.


https://issues.apache.org/jira/browse/MRESOLVER-547

No need for full copy, Artifact is already immutable.
Moreover, the instance may be not DefaultArtifact but
something else. And finally, setVersion already
have "optimization" to return this if version is
same as the one we want to copy with.

---

https://issues.apache.org/jira/browse/MRESOLVER-547
@cstamas cstamas self-assigned this Apr 25, 2024
@cstamas cstamas marked this pull request as ready for review April 25, 2024 17:07
@cstamas cstamas merged commit 4f16d5e into apache:maven-resolver-1.9.x Apr 25, 2024
10 checks passed
@cstamas cstamas deleted the maven-resolver-1.9.x-MRESOLVER-547 branch April 25, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant