[MSHARED-1269] Deprecate maven-shared-utils #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
requested changes
Jun 16, 2023
|
Where we can get rid of this, do so. There are many cases where there's better in the JDK or Apache commons these days. But we should not replace this with plexus utils. |
|
The more I look at this the more places I find where these two have diverged. E.g. plexus-utils does not seem to have any equivalent of org.apache.maven.shared.utils.logging. Even after a package rename it's not a drop-in replacement. I don't think this proposal is feasible. |
Here I agree with @elharo, even more many plexus components have an unclear licenses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.apache.org/jira/browse/MSHARED-1269
Maven-shared-utils was created so that plexus-utils could be deprecated on kinda come back into the maven land. However, this did never happened and we end-up with the exact same library duplicated and duplicate maintenance effort.
The only problematic point is the
org.apache.maven.shared.utils.loggingpackage which is used by several components and does not exists in plexus-utils. Maven 4 provides a similar API already with theMessageBuilderFactoryservice which allows the creation ofMessageBuilder. I thus propose to get rid completely of maven-shared-utils.The maven PR get rid of maven-shared-utils in maven core.