-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Downgrade model version in consumer/build pom as needed
- Loading branch information
Showing
14 changed files
with
693 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
maven-core/src/test/resources/projects/transform/consumer-after.pom
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>test</groupId> | ||
| <artifactId>test</artifactId> | ||
| <version>0.1-SNAPSHOT</version> | ||
| <packaging>pom</packaging> | ||
| <modules> | ||
| <module>lib</module> | ||
| <module>app</module> | ||
| </modules> | ||
| <profiles> | ||
| <profile> | ||
| <id>default-active</id> | ||
| <activation> | ||
| <activeByDefault>true</activeByDefault> | ||
| </activation> | ||
| </profile> | ||
| <profile> | ||
| <id>file</id> | ||
| <activation> | ||
| <file> | ||
| <exists>simple.xml</exists> | ||
| </file> | ||
| </activation> | ||
| </profile> | ||
| </profiles> | ||
| </project> |
87 changes: 87 additions & 0 deletions
87
maven-core/src/test/resources/projects/transform/consumer-before.pom
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.1.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd" | ||
| root="true"> | ||
| <modelVersion>4.1.0</modelVersion> | ||
|
|
||
| <groupId>test</groupId> | ||
| <artifactId>test</artifactId> | ||
| <version>0.1-SNAPSHOT</version> | ||
| <packaging>pom</packaging> | ||
|
|
||
| <modules> | ||
| <module>lib</module> <!-- the library --> | ||
| <module>app</module> <!-- the application --> | ||
| </modules> | ||
|
|
||
| <build> | ||
| <pluginManagement> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>2.1</version> | ||
| <configuration> | ||
| <source> 1.5 </source> | ||
| <target xml:space="preserve"> 1.5 </target> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <id>test</id> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| <profiles> | ||
| <profile> | ||
| <id>default-active</id> | ||
| <activation> | ||
| <activeByDefault>true</activeByDefault> | ||
| </activation> | ||
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> | ||
| </profile> | ||
| <profile> | ||
| <id>file</id> | ||
| <activation> | ||
| <file> | ||
| <exists>simple.xml</exists> | ||
| </file> | ||
| </activation> | ||
| <properties> | ||
| <profile.file>activated</profile.file> | ||
| </properties> | ||
| </profile> | ||
| </profiles> | ||
| </project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
...nsform/src/main/java/org/apache/maven/model/transform/ModelVersionDowngradeXMLFilter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.maven.model.transform; | ||
|
|
||
| import javax.xml.stream.XMLStreamException; | ||
| import javax.xml.stream.XMLStreamReader; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import org.apache.maven.api.model.Model; | ||
| import org.apache.maven.model.transform.stax.BufferingParser; | ||
| import org.apache.maven.model.v4.MavenModelVersion; | ||
| import org.apache.maven.model.v4.MavenStaxReader; | ||
|
|
||
| public class ModelVersionDowngradeXMLFilter extends BufferingParser { | ||
|
|
||
| public static final String NAMESPACE_PREFIX = "http://maven.apache.org/POM/"; | ||
|
|
||
| private final List<Event> buffer = new ArrayList<>(); | ||
|
|
||
| public ModelVersionDowngradeXMLFilter(XMLStreamReader delegate) { | ||
| super(delegate); | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean accept() throws XMLStreamException { | ||
| Event e = bufferEvent(); | ||
| buffer.add(e); | ||
| if (e.event == XMLStreamReader.END_DOCUMENT) { | ||
| ReplayParser p = new ReplayParser(this); | ||
| buffer.forEach(p::pushEvent); | ||
| p.next(); | ||
| String version; | ||
| Model model = new MavenStaxReader().read(p, false, null); | ||
| if (model.isDowngradeModelVersion()) { | ||
| model = model.withDowngradeModelVersion(false); | ||
| version = new MavenModelVersion().getModelVersion(model); | ||
| } else { | ||
| version = model.getModelVersion(); | ||
| } | ||
| int depth = 0; | ||
| boolean isModelVersion = false; | ||
| for (Event event : buffer) { | ||
| event.namespace = NAMESPACE_PREFIX + version; | ||
| // rewrite namespace | ||
| if (event.namespaces != null) { | ||
| for (int i = 0; i < event.namespaces.length; i++) { | ||
| if (event.namespaces[i].uri.startsWith(NAMESPACE_PREFIX)) { | ||
| event.namespaces[i].uri = event.namespace; | ||
| } | ||
| } | ||
| } | ||
| // rewrite xsi:schemaLocation attribute | ||
| if (event.attributes != null) { | ||
| for (Attribute attribute : event.attributes) { | ||
| if (attribute.namespace.equals("http://www.w3.org/2001/XMLSchema-instance") | ||
| && attribute.name.equals("schemaLocation")) { | ||
| attribute.value = attribute | ||
| .value | ||
| .replaceAll( | ||
| "\\Q" + NAMESPACE_PREFIX + "\\E[0-9]\\.[0-9]\\.[0-9]", | ||
| NAMESPACE_PREFIX + version) | ||
| .replaceAll( | ||
| "http(s?)://maven\\.apache\\.org/xsd/maven-[0-9]\\.[0-9]\\.[0-9]\\.xsd", | ||
| "https://maven.apache.org/xsd/maven-" + version + ".xsd"); | ||
| } | ||
| } | ||
| } | ||
| // Rewrite modelVersion | ||
| if (event.event == XMLStreamReader.START_ELEMENT) { | ||
| depth++; | ||
| isModelVersion = depth == 2 && event.name.equals("modelVersion"); | ||
| } | ||
| if (event.event == XMLStreamReader.CHARACTERS && isModelVersion) { | ||
| event.text = version; | ||
| } | ||
| if (event.event == XMLStreamReader.END_ELEMENT) { | ||
| depth--; | ||
| isModelVersion = false; | ||
| } | ||
| pushEvent(event); | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| static class ReplayParser extends BufferingParser { | ||
| ReplayParser(XMLStreamReader delegate) { | ||
| super(delegate); | ||
| } | ||
|
|
||
| public void pushEvent(Event e) { | ||
| super.pushEvent(e); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.